Add terraform config to support locality aware routing in ECS #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthain
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
I had a couple of minor nits/suggestions but nothing blocking. I couldn't actually run the example because I kept getting permission denied errors when trying to create secrets in secret manager. I think this is a restriction on my account.
Approving based on 👀 of the code.
Co-authored-by: Chris Thain <[email protected]>
…rm-aws-consul-ecs into locality-aware-routing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
Manually deployed the terraform to check if the client app hits the server present in its locality (AZ)
How I expect reviewers to test this PR:
Checklist: